Dts Grpc client retry support #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunchuWang
requested review from
cgillum,
jviau and
nytian
and removed request for
nytian
cgillum
reviewed
Mar 28, 2025
nytian
reviewed
Mar 28, 2025
cgillum
approved these changes
Mar 28, 2025
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
Latest iteration looks good to me.
Thank you @nytian for also providing feedback. If you are good, I think we can go ahead and merge this.
@YunchuWang, if you intend to merge this PR yourself, please do not use the default commit message when squash merging this PR. It will contain all the "fb" and "refactor" commit descriptions which is not good to have in our commit history. Please delete those and put the PR description in the commit message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
DurableTaskSchedulerClientOptionsandDurableTaskSchedulerWorkerOptionsclasses to enhance retry policies and improve code clarity. The most important changes include adding a retry policy configuration for gRPC calls and refining the instantiation ofWorkloadIdentityCredentialOptions.Enhancements to retry policies:
src/Client/AzureManaged/DurableTaskSchedulerClientOptions.cs: Added aServiceConfigwith aRetryPolicyto configure retry behavior for gRPC calls. This includes setting maximum attempts, backoff intervals, and retryable status codes.src/Worker/AzureManaged/DurableTaskSchedulerWorkerOptions.cs: Added a similarServiceConfigwith aRetryPolicyto configure retry behavior for gRPC calls in the worker options.Code clarity improvements:
src/Client/AzureManaged/DurableTaskSchedulerClientOptions.cs: Changed the instantiation ofWorkloadIdentityCredentialOptionsto use explicit type declaration for better readability.src/Worker/AzureManaged/DurableTaskSchedulerWorkerOptions.cs: Made the same change to the instantiation ofWorkloadIdentityCredentialOptionsfor consistency and readability.